installer: install the tick processor #3032

matthewloring · 2015-09-23T18:15:46Z

The tick processor is used to provide readable profiling information
from isolate tick logs (produced by a call to node -prof).

This patch installs the file at $PREFIX/share/doc/node/tick-processor.

/cc @bnoordhuis @ofrobots

matthewloring · 2015-09-23T18:17:47Z

I haven't been able to check this on windows. I'm also not sure how this script is invoked on windows (there does seem to be windows specific logic inside it but it also has unix paths).

ofrobots · 2015-10-08T23:30:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/460/.

ofrobots · 2015-10-09T00:49:33Z

/cc @nodejs/platform-windows This makes it really simple to do profiling with Node.js without any additional tools needing to be installed. Any ideas on what would be needed to extend this to windows?

richardlau · 2015-11-25T03:50:47Z

@ofrobots AFAIK tools/install.py is not called on Windows (which is built via vcbuild.bat instead of using the Makefile). Instead you'll need to modify the msi installer project files located in tools/msvs/msi.

bnoordhuis · 2015-11-25T12:36:23Z

LGTM but @richardlau is right, the Windows installer doesn't use tools/install.py. The Mac installer should pick it up automatically though, I think.

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor.

matthewloring · 2015-11-25T12:46:06Z

@bnoordhuis @richardlau I've removed the windows specific logic from this PR but I have not modified the previously existing windows checks in install.py which sound like they shouldn't be there. If it's alright, I'll leave the windows installation to another PR and keep this to mac/linux for now.

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: #3032 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

bnoordhuis · 2015-11-25T13:07:53Z

Thanks, landed in b2e7a4d.

This might be a good candidate for cherry-picking into the LTS branch but there are a few things to resolve first:

$prefix/share/doc is perhaps not the best place to drop an executable script.
tick-processor should maybe be renamed to node-tick-processor.
The user experience is a little confusing at times. For example, if you invoke it without arguments, it throws the following exception:

$ $HOME/opt/node/share/doc/node/tick-processor 
fs.js:585
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

TypeError: path must be a string
    at TypeError (native)
    at Object.fs.openSync (fs.js:585:18)
    at Object.<anonymous> (/home/bnoordhuis/opt/node/share/doc/node/tick-processor:54:13)
   <snip>

richardlau · 2015-11-25T14:56:57Z

Looks like the existing Windows checks in install.py originated from nodejs/node-v0.x-archive#8294 for MSYS2/MinGW-w64.

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: #3032 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This change cleans up outstanding comments on #3032. It improves error handling when no isolate file is provided and adds the --prof-process flag to the node binary which executes the tick processor on the provided isolate file. PR-URL: #4021 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>

jasnell · 2015-12-17T19:53:20Z

Marking this lts-watch for v4 for there appear to be some issues to resolve first before it can land. See #3032 (comment)

matthewloring · 2015-12-17T19:59:37Z

@jasnell These comments were addressed in #4021 which already landed. As a heads up, there are further changes in the pipeline with #4224 (still in review).

MylesBorins · 2015-12-29T21:09:06Z

waiting on #4224 before landing this in LTS

matthewloring · 2015-12-29T21:41:14Z

@thealphanerd #4224 should be ready to land. Has an LGTM and a green CI.

MylesBorins · 2015-12-29T22:09:45Z

oh excellent! That will have to land on master and make it's way to a release channel before heading to LTS

MylesBorins · 2016-01-08T17:17:54Z

@matthewloring most likely if we want to get all of these into LTS we will need #4021 to be approved by the CTC to merge into LTS as a semver minor. I'll add the appropriate flags.

jasnell · 2016-02-17T18:40:33Z

@nodejs/lts ... please weigh in on this one. This LGTM for v4.4

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: nodejs#3032 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This change cleans up outstanding comments on nodejs#3032. It improves error handling when no isolate file is provided and adds the --prof-process flag to the node binary which executes the tick processor on the provided isolate file. PR-URL: nodejs#4021 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: #3032 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This change cleans up outstanding comments on #3032. It improves error handling when no isolate file is provided and adds the --prof-process flag to the node binary which executes the tick processor on the provided isolate file. PR-URL: #4021 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>

In December we announced that we would be doing a minor release in order to get a number of voted on SEMVER-MINOR changes into LTS. Our ability to release this was delayed due to the unforeseen security release v4.3. We are quickly bumping to v4.4 in order to bring you the features that we had committed to releasing. This release also includes security updates to openssl. More information can be found [on nodejs.org](https://nodejs.org/en/blog/vulnerability/openssl-march-2016/) This release also includes over 70 fixes to our docs and over 50 fixes to tests. The SEMVER-MINOR changes include: * deps: - An update to v8 that introduces a new flag --perf_basic_prof_only_functions (Ali Ijaz Sheikh) #3609 * http: - A new feature in http(s) agent that catches errors on *keep alived* connections (José F. Romaniello) #4482 * src: - Better support for Big-Endian systems (Bryon Leung) #3410 * tls: - A new feature that allows you to pass common SSL options to `tls.createSecurePair` (Коренберг Марк) #2441 * tools - a new flag `--prof-process` which will execute the tick processor on the provided isolate files (Matt Loring) #4021 Notable semver patch changes include: * buld: - Support python path that includes spaces. This should be of particular interest to our Windows users who may have python living in `c:/Program Files` (Felix Becker) #4841 * https: - A potential fix for #3692 HTTP/HTTPS client requests throwing EPROTO (Fedor Indutny) #4982 * installer: - More readable profiling information from isolate tick logs (Matt Loring) #3032 * *npm: - upgrade to npm 2.14.20 (Kat Marchán) #5510 * *openssl: - upgrade openssl to 1.0.2g (Ben Noordhuis) #5507 * process: - Add support for symbols in event emitters. Symbols didn't exist when it was written ¯\_(ツ)_/¯ (cjihrig) #4798 * querystring: - querystring.parse() is now 13-22% faster! (Brian White) #4675 * streams: - performance improvements for moving small buffers that shows a 5% throughput gain. IoT projects have been seen to be as much as 10% faster with this change! (Matteo Collina) #4354 * tools: - eslint has been updated to version 2.1.0 (Rich Trott) #5214 PR-URL: #5301

In December we announced that we would be doing a minor release in order to get a number of voted on SEMVER-MINOR changes into LTS. Our ability to release this was delayed due to the unforeseen security release v4.3. We are quickly bumping to v4.4 in order to bring you the features that we had committed to releasing. This release also includes security updates to openssl. More information can be found [on nodejs.org](https://nodejs.org/en/blog/vulnerability/openssl-march-2016/) This release also includes over 70 fixes to our docs and over 50 fixes to tests. The SEMVER-MINOR changes include: * deps: - An update to v8 that introduces a new flag --perf_basic_prof_only_functions (Ali Ijaz Sheikh) nodejs#3609 * http: - A new feature in http(s) agent that catches errors on *keep alived* connections (José F. Romaniello) nodejs#4482 * src: - Better support for Big-Endian systems (Bryon Leung) nodejs#3410 * tls: - A new feature that allows you to pass common SSL options to `tls.createSecurePair` (Коренберг Марк) nodejs#2441 * tools - a new flag `--prof-process` which will execute the tick processor on the provided isolate files (Matt Loring) nodejs#4021 Notable semver patch changes include: * buld: - Support python path that includes spaces. This should be of particular interest to our Windows users who may have python living in `c:/Program Files` (Felix Becker) nodejs#4841 * https: - A potential fix for nodejs#3692 HTTP/HTTPS client requests throwing EPROTO (Fedor Indutny) nodejs#4982 * installer: - More readable profiling information from isolate tick logs (Matt Loring) nodejs#3032 * *npm: - upgrade to npm 2.14.20 (Kat Marchán) nodejs#5510 * *openssl: - upgrade openssl to 1.0.2g (Ben Noordhuis) nodejs#5507 * process: - Add support for symbols in event emitters. Symbols didn't exist when it was written ¯\_(ツ)_/¯ (cjihrig) nodejs#4798 * querystring: - querystring.parse() is now 13-22% faster! (Brian White) nodejs#4675 * streams: - performance improvements for moving small buffers that shows a 5% throughput gain. IoT projects have been seen to be as much as 10% faster with this change! (Matteo Collina) nodejs#4354 * tools: - eslint has been updated to version 2.1.0 (Rich Trott) nodejs#5214 PR-URL: nodejs#5301

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: #3032 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This change cleans up outstanding comments on #3032. It improves error handling when no isolate file is provided and adds the --prof-process flag to the node binary which executes the tick processor on the provided isolate file. PR-URL: #4021 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>

In December we announced that we would be doing a minor release in order to get a number of voted on SEMVER-MINOR changes into LTS. Our ability to release this was delayed due to the unforeseen security release v4.3. We are quickly bumping to v4.4 in order to bring you the features that we had committed to releasing. This release also includes over 70 fixes to our docs and over 50 fixes to tests. The SEMVER-MINOR changes include: * deps: - An update to v8 that introduces a new flag --perf_basic_prof_only_functions (Ali Ijaz Sheikh) #3609 * http: - A new feature in http(s) agent that catches errors on *keep alived* connections (José F. Romaniello) #4482 * src: - Better support for Big-Endian systems (Bryon Leung) #3410 * tls: - A new feature that allows you to pass common SSL options to `tls.createSecurePair` (Коренберг Марк) #2441 * tools - a new flag `--prof-process` which will execute the tick processor on the provided isolate files (Matt Loring) #4021 Notable semver patch changes include: * buld: - Support python path that includes spaces. This should be of particular interest to our Windows users who may have python living in `c:/Program Files` (Felix Becker) #4841 * https: - A potential fix for #3692 HTTP/HTTPS client requests throwing EPROTO (Fedor Indutny) #4982 * installer: - More readable profiling information from isolate tick logs (Matt Loring) #3032 * *npm: - upgrade to npm 2.14.20 (Kat Marchán) #5510 * process: - Add support for symbols in event emitters. Symbols didn't exist when it was written ¯\_(ツ)_/¯ (cjihrig) #4798 * querystring: - querystring.parse() is now 13-22% faster! (Brian White) #4675 * streams: - performance improvements for moving small buffers that shows a 5% throughput gain. IoT projects have been seen to be as much as 10% faster with this change! (Matteo Collina) #4354 * tools: - eslint has been updated to version 2.1.0 (Rich Trott) #5214 PR-URL: #5301

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: nodejs#3032 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This change cleans up outstanding comments on nodejs#3032. It improves error handling when no isolate file is provided and adds the --prof-process flag to the node binary which executes the tick processor on the provided isolate file. PR-URL: nodejs#4021 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>

matthewloring mentioned this pull request Sep 23, 2015

Help with installing the tick processor by default nodejs/build#198

Closed

mscdex added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. labels Sep 23, 2015

installer: install the tick processor

5e92c28

The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor.

bnoordhuis closed this Nov 25, 2015

matthewloring mentioned this pull request Nov 25, 2015

tools: change tick processor install path #4021

Closed

Fishrock123 mentioned this pull request Nov 26, 2015

deps: upgrade npm to 3.5.0 #4032

Closed

This was referenced Dec 8, 2015

Release proposal: v5.2.0 #4180

Closed

Release proposal: v5.2.0 (Stable) #4181

Merged

rvagg mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

jasnell added the lts-watch-v4.x label Dec 17, 2015

Trott mentioned this pull request Jan 5, 2016

Profiling Guide Requires Updates nodejs/nodejs.org#447

Closed

matthewloring mentioned this pull request Jan 8, 2016

Update guide: "Easy profiling for Node.js" nodejs/nodejs.org#449

Closed

MylesBorins added the lts-agenda label Jan 8, 2016

MylesBorins mentioned this pull request Jan 11, 2016

LTS WG Meeting 2015-01-11 nodejs/Release#67

Closed

matthewloring deleted the tick-install branch February 25, 2016 19:55

MylesBorins added land-on-v4.x and removed lts-agenda labels Mar 1, 2016

MylesBorins mentioned this pull request Mar 1, 2016

V4.4.0 proposal #5301

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

installer: install the tick processor #3032

installer: install the tick processor #3032

matthewloring commented Sep 23, 2015

matthewloring commented Sep 23, 2015

ofrobots commented Oct 8, 2015

ofrobots commented Oct 9, 2015

richardlau commented Nov 25, 2015

bnoordhuis commented Nov 25, 2015

matthewloring commented Nov 25, 2015

bnoordhuis commented Nov 25, 2015

richardlau commented Nov 25, 2015

jasnell commented Dec 17, 2015

matthewloring commented Dec 17, 2015

MylesBorins commented Dec 29, 2015

matthewloring commented Dec 29, 2015

MylesBorins commented Dec 29, 2015

MylesBorins commented Jan 8, 2016

jasnell commented Feb 17, 2016

installer: install the tick processor #3032

installer: install the tick processor #3032

Conversation

matthewloring commented Sep 23, 2015

matthewloring commented Sep 23, 2015

ofrobots commented Oct 8, 2015

ofrobots commented Oct 9, 2015

richardlau commented Nov 25, 2015

bnoordhuis commented Nov 25, 2015

matthewloring commented Nov 25, 2015

bnoordhuis commented Nov 25, 2015

richardlau commented Nov 25, 2015

jasnell commented Dec 17, 2015

matthewloring commented Dec 17, 2015

MylesBorins commented Dec 29, 2015

matthewloring commented Dec 29, 2015

MylesBorins commented Dec 29, 2015

MylesBorins commented Jan 8, 2016

jasnell commented Feb 17, 2016